javascript - Calling done on an array of http.get requests in Node.js -

-

i have array of urls i'm using loop call http.get requests. since async process, i'd call done after requests have returned.

here current attempt:

grunt.registertask('verify', function() {     var done = this.async();     var promises = [];     var urlprefix = 'http://example.com/';     for(var = 0; < deployablefiles.length; i++) {          (function(i) {             var deferred = q.defer();             promises.push(deferred);             var file = deployablefiles[i];             var path =  file.filetype + '/' + getversionedfilename(file.basename, file.filetype);             http.get(urlprefix + path, function(res) {                 deferred.resolve();                 if(res.statuscode === 200) {                     grunt.log.oklns(path + ' found on production server.');                 } else {                     grunt.log.error('error! ' + path + ' not found on production server!');                 }             }).on('error', function(e) {                 grunt.log.error("got error: " + e.message);                 done();             });         })(i);     }      q.all(promises)     .done(function() {         // executed correctly         return done();     }, function(reason) {         // there error somewhere         return done(false);     }); });

i'm sure it's me not wrapping head around whole async nature of node correctly, there glaringly obvious else?

i've searched using http q library, , appears might required use q.nfcall work. i'm having trouble seeing why i'd have that. (i'm not adverse doing that, i'm more curious else)

thanks!

you should perform promisification @ lowest level possible. makes reasoning concurrency lot easier.

function getping(url){     return new q.promise(function(resolve,reject){          http.get(url,function(res){              // note _not_ wait whole request              // headers.              if(res.statuscode === 200) resolve();              else reject();          });     }); }

this let do:

grunt.registertask('verify', function() {     var done = this.async();     var urlprefix = 'http://example.com/';     var pings = deployablefiles.map(function(file){         var path =  file.filetype + '/' +                          getversionedfilename(file.basename, file.filetype);         return getping(urlprefix + path);     });     q.all(pings).then(done).catch(function(reason) {         // there error somewhere         // happen _one_ promise rejected         return done(false);     }); });

this can further shortened using better promise library bluebird.


Comments

Post a Comment

Popular posts from this blog

database - VFP Grid + SQL server 2008 - grid not showing correctly -

-
i having problem, have grid called "gridbasica" , this: thisform.gridbase.recordsource = "sgviemp" sgviemp cursor made executing select sqlserver command sqlexec. when want modify registry, go form , the update there. so, when come form grid, grid isnt grid anymore, big white rectangle. reading around said: delete recordsource , asingt again. thisform.gridbase.recordsource = "" *--i sqlexe here thisform.gridbase.recordsource = "sgviemp" i , works, but, when click button modify again cursos updated modify form doesnt load fields did first time. could me out that? thanks in advance. --------------- edit ------------------ i have been doing recommended: lnselect = select(0) n = sqlexec(thisform.conexion,"select emp_ccodigo codigo, emp_cnombre 'nombre o razon social', emp_cnumrif 'r.i.f' sgviempr","sgviemp1") set echo on suspend select sgviemp zap in sgviemp *-- browse *--zaps correct
Read more

jquery - Set jPicker field to empty value -

-
im using jpicker color selector in form. have clear value set window/icon 'no color selected' state. i've tried following: $(':input[name="color"]').val(''); //access value directly. (does not affect jpicker) 2: $.jpicker.list[0].color.active.val('hex', '', this); //set color black , input value 000000, instead of empty string 3: $.jpicker.list[0].color.active.val(null, '', this); //does nothing none of 3 methods seems behave properly. in advance. this works me :) $.jpicker.list[0].color.active.val('v', null); here example: http://jsfiddle.net/3up7n/
Read more

.htaccess - htaccess convert request to clean url and add slash at the end of the url -

-
ok , searched more 4 days , more 20 posts here in stach or in websites without kind of success first here htaccess file rewriteengine on rewriterule ^([a-za-z0-9_]+)/?$ index.php?page=$1 [nc] rewriterule ^([a-za-z0-9_]+)\/([a-za-z0-9_]+)\/?$ index.php?page=$1&action=$2 [nc] i tried many codes 1 worked me can call request , works me www.example.com/pagename => www.example.com/index.php?page=pagename here questions , please provide me information "in detail" understand code well 1- how convert request automatically www.example.com/index.php?page=pagename www.example.com/pagename 2- if tried add slash @ end shows me page without images or styling mean www.example.com/pagename => works www.example.com/pagename/ => doesn't work that's :) for first part need 301 rule this: rewritecond %{the_request} /index\.php\?page=([^\s&]+) [nc] rewriterule ^ /%1? [r=301,l] for second part use absolute path in css, js, images files r
Read more