javascript - Calling done on an array of http.get requests in Node.js -

-

i have array of urls i'm using loop call http.get requests. since async process, i'd call done after requests have returned.

here current attempt:

grunt.registertask('verify', function() {     var done = this.async();     var promises = [];     var urlprefix = 'http://example.com/';     for(var = 0; < deployablefiles.length; i++) {          (function(i) {             var deferred = q.defer();             promises.push(deferred);             var file = deployablefiles[i];             var path =  file.filetype + '/' + getversionedfilename(file.basename, file.filetype);             http.get(urlprefix + path, function(res) {                 deferred.resolve();                 if(res.statuscode === 200) {                     grunt.log.oklns(path + ' found on production server.');                 } else {                     grunt.log.error('error! ' + path + ' not found on production server!');                 }             }).on('error', function(e) {                 grunt.log.error("got error: " + e.message);                 done();             });         })(i);     }      q.all(promises)     .done(function() {         // executed correctly         return done();     }, function(reason) {         // there error somewhere         return done(false);     }); });

i'm sure it's me not wrapping head around whole async nature of node correctly, there glaringly obvious else?

i've searched using http q library, , appears might required use q.nfcall work. i'm having trouble seeing why i'd have that. (i'm not adverse doing that, i'm more curious else)

thanks!

you should perform promisification @ lowest level possible. makes reasoning concurrency lot easier.

function getping(url){     return new q.promise(function(resolve,reject){          http.get(url,function(res){              // note _not_ wait whole request              // headers.              if(res.statuscode === 200) resolve();              else reject();          });     }); }

this let do:

grunt.registertask('verify', function() {     var done = this.async();     var urlprefix = 'http://example.com/';     var pings = deployablefiles.map(function(file){         var path =  file.filetype + '/' +                          getversionedfilename(file.basename, file.filetype);         return getping(urlprefix + path);     });     q.all(pings).then(done).catch(function(reason) {         // there error somewhere         // happen _one_ promise rejected         return done(false);     }); });

this can further shortened using better promise library bluebird.


Comments

Post a Comment

Popular posts from this blog

C# random value from dictionary and tuple -

-
i have following code, , need random item contains string "region_1" dictionary. public static dictionary<int, tuple<string, int, currencytype>> itemarray = new dictionary<int, tuple<string, int, currencytype>>() { { 0xb3e, new tuple<string, int, currencytype>("region_1", 1500, currencytype.fame) } }; public static int generateitemid(string shopid) { var generateditem = itemarray.elementat(new random().next(0, itemarray.count)).key; } how select this? it's not possible efficiently... first create static random @ class level... prevent non-random behaviour if run query on short period of time... (it's seeded discrete clock) static random rnd = new random(); then: var item = itemarray.values .where(t => t.item1 == shopid) .orderby(_ => rnd.next()) .firstordefault()
Read more

cgi - How do I interpret URLs without extension as files rather than missing directories in nginx? -

-
so i'm trying install zoneminder , have run under nginx, has few compiled files need run using fast-cgi. these files lack extension. if file has extension, there no issue , nginx interprets file , return 404 if can't find it. if has no extension, assume it's directory , return 404 when can't find sort of index page. here have now: # security camera domain. server { listen 888; server_name mydomain.com; root /srv/http/zm; # enable php support. include php.conf; location / { index index.html index.htm index.php; } # enable cgi support. location ~ ^/cgi-bin/(.+)$ { alias /srv/cgi-bin/zm/; fastcgi_pass unix:/run/fcgiwrap.sock; fastcgi_param script_filename $document_root/$1; include fastcgi.conf; } } the idea is, under cgi-bin directory goes through fastcgi pipe. any idea on howi can fix this? upon closer inspection, realized zoneminder has 2 cgi sc...
Read more

.htaccess - htaccess convert request to clean url and add slash at the end of the url -

-
ok , searched more 4 days , more 20 posts here in stach or in websites without kind of success first here htaccess file rewriteengine on rewriterule ^([a-za-z0-9_]+)/?$ index.php?page=$1 [nc] rewriterule ^([a-za-z0-9_]+)\/([a-za-z0-9_]+)\/?$ index.php?page=$1&action=$2 [nc] i tried many codes 1 worked me can call request , works me www.example.com/pagename => www.example.com/index.php?page=pagename here questions , please provide me information "in detail" understand code well 1- how convert request automatically www.example.com/index.php?page=pagename www.example.com/pagename 2- if tried add slash @ end shows me page without images or styling mean www.example.com/pagename => works www.example.com/pagename/ => doesn't work that's :) for first part need 301 rule this: rewritecond %{the_request} /index\.php\?page=([^\s&]+) [nc] rewriterule ^ /%1? [r=301,l] for second part use absolute path in css, js, images files r...
Read more