c++ - Segmentation fault (core dumped) while creating binary tree of given height -

-

this first time working trees. wrote c++ code, says segmentation fault (core dumped) , far searched, error comes accessing memory location may null. tried 'new' keyword malloc() should avoided in c++, still didn't how resolve in code.

# include<iostream> using namespace std; struct node {     int data;     node *left;     node *right; }*next;  int k=0;  void tree(int i,/*struct*/ node *next = new node) {   ++k; --i;   if (i==0)     return;   //next = new node;   next->data = k*k;   next->left = null;   next->right = null;   tree(i, next->left);   tree(i, next->right);   return ;  }   void display (node* next)  {   cout<<next->data<<" ";   if (next->left!=null)     {         display(next->left);         display(next->right);     }  }  int main()  {    int h;    cout<<"enter expected height of tree : ";    cin>>h;    node *root;    root = new node;    root->data=0;    root->left=null;    root->right=null;    tree(h, (root->left));    tree(h, (root->right));    cout<<root->data<<" ";    display(root->left);    display(root->right);    return 0;  } 

#include <iostream>  using namespace std;  struct node {     int data;     struct node *left;     struct node *right; };  void tree(int i, struct node **root, int k) {     if (i < 1)         return;      *root = new struct node;     (*root)->data = k*k;     (*root)->left = null;     (*root)->right = null;     tree(i - 1, &((*root)->left), k + 1);     tree(i - 1, &((*root)->right), k + 1); }  void display(struct node *root) {     if (root == null)         return;     cout << root->data << " ";     if (root->left != null)          display(root->left);     if (root->right != null)         display(root->right); }  int main() {     struct node *root;     int h;      cout<<"enter expected height of tree : ";     cin>>h;     tree(h, &root, 0);     display(root);     return 0; }

i think should more read on how pointers works: http://www.tutorialspoint.com/cprogramming/c_pointers.htm

when calling tree(h, root->left) send pointers value "null" == 0x0. want allocate memory should send reference pointer. hence &root , &((*root)->left). in display function have check null values both left , right.

the code above improved , doesn't handle freeing of memory, able that, traverse tree , use delete on leafs , work root.


Comments

Post a Comment

Popular posts from this blog

C# random value from dictionary and tuple -

-
i have following code, , need random item contains string "region_1" dictionary. public static dictionary<int, tuple<string, int, currencytype>> itemarray = new dictionary<int, tuple<string, int, currencytype>>() { { 0xb3e, new tuple<string, int, currencytype>("region_1", 1500, currencytype.fame) } }; public static int generateitemid(string shopid) { var generateditem = itemarray.elementat(new random().next(0, itemarray.count)).key; } how select this? it's not possible efficiently... first create static random @ class level... prevent non-random behaviour if run query on short period of time... (it's seeded discrete clock) static random rnd = new random(); then: var item = itemarray.values .where(t => t.item1 == shopid) .orderby(_ => rnd.next()) .firstordefault()
Read more

cgi - How do I interpret URLs without extension as files rather than missing directories in nginx? -

-
so i'm trying install zoneminder , have run under nginx, has few compiled files need run using fast-cgi. these files lack extension. if file has extension, there no issue , nginx interprets file , return 404 if can't find it. if has no extension, assume it's directory , return 404 when can't find sort of index page. here have now: # security camera domain. server { listen 888; server_name mydomain.com; root /srv/http/zm; # enable php support. include php.conf; location / { index index.html index.htm index.php; } # enable cgi support. location ~ ^/cgi-bin/(.+)$ { alias /srv/cgi-bin/zm/; fastcgi_pass unix:/run/fcgiwrap.sock; fastcgi_param script_filename $document_root/$1; include fastcgi.conf; } } the idea is, under cgi-bin directory goes through fastcgi pipe. any idea on howi can fix this? upon closer inspection, realized zoneminder has 2 cgi sc...
Read more

.htaccess - htaccess convert request to clean url and add slash at the end of the url -

-
ok , searched more 4 days , more 20 posts here in stach or in websites without kind of success first here htaccess file rewriteengine on rewriterule ^([a-za-z0-9_]+)/?$ index.php?page=$1 [nc] rewriterule ^([a-za-z0-9_]+)\/([a-za-z0-9_]+)\/?$ index.php?page=$1&action=$2 [nc] i tried many codes 1 worked me can call request , works me www.example.com/pagename => www.example.com/index.php?page=pagename here questions , please provide me information "in detail" understand code well 1- how convert request automatically www.example.com/index.php?page=pagename www.example.com/pagename 2- if tried add slash @ end shows me page without images or styling mean www.example.com/pagename => works www.example.com/pagename/ => doesn't work that's :) for first part need 301 rule this: rewritecond %{the_request} /index\.php\?page=([^\s&]+) [nc] rewriterule ^ /%1? [r=301,l] for second part use absolute path in css, js, images files r...
Read more